Re: [Xen-devel][Xense-devel][PATCH][1/4] Xen Security Modules: XSM

[Mark Williamson <mark.williamson@xxxxxxxxxxxx>]

> Does your tool have a pretty-printing capability? It seems like it would
> be more efficient to just reformat the source to comply with whatever
> standards Xen follows. Everyone could apply the tool before building
> patches or submitting code, but still use their own locally preferred
> style while developing.

It doesn't have this capability at the moment.  It's just a version of the 
Linux patchstylecheckemail.pl that I've modified to understand the different 
coding conventions in Xen.  GNU indent can quite possibly be configured to 
reformat the code as required - I'll look into finding a configuration setup 
that works for this (I'll probably start with the Linux lindent script and 
work from there - we're reasonably close to Linux conventions in many ways).

The style checker does various checks beyond indenting, though, so it'll still 
be worth running it.  I hope to get the it into mainline Xen at some point so 
that folks can just "make stylecheck" or similar before they submit patches.

Thanks for the feedback!

Cheers,
Mark

-- 
Dave: Just a question. What use is a unicyle with no seat?  And no pedals!
Mark: To answer a question with a question: What use is a skateboard?
Dave: Skateboards have wheels.
Mark: My wheel has a wheel!

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel