Re: [Xen-devel][Xense-devel][PATCH][1/4] Xen Security Modules: X

To:	"Chris Wright" <chrisw@xxxxxxxxxxxx>
Subject:	Re: [Xen-devel][Xense-devel][PATCH][1/4] Xen Security Modules: XSM
From:	"George S. Coker, II" <george.coker@xxxxxxxxx>
Date:	Mon, 7 May 2007 21:12:21 -0400
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx, "George S. Coker, II" <gscoker@xxxxxxxxxxxxxx>, xense-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Mon, 07 May 2007 18:10:47 -0700
Dkim-signature:	a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=ASHgf92Bdo5Afcqql+Bwzi6G+goeCSVxMTaH7n7m5u7AlOKoSDY//p6xP1OYPQQmMT/GCltnmQYFwf8HrxwDMz1DTh3qCb3Lbc35sAlbcZGLabM3fttMMLRA/e02izmN2kZt/12PDFwnt08m2s5v+dFnLY0x+/cgf0QNhEylyCU=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=e3IdWDw4NS8R7Qigkn+T6UZuFbveRu6yHsLzzTPNrRfNGgd6OekWjcoa56ppz7p75HkzsGjkPwfU75tSaMH/ZaEQ4YfUAoRr2t+HvdWoM0Jo2JT/swbWPDL7xaRbTpp/4hC+TM9upx0wLJUoZg9LBJs5V2TNyK1FHjYP9p0qZqg=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<ff0b9d4e0705071759q1b46d942ydef5fa5008071764@xxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<1178574070.6520.87.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <20070507231029.GA7531@xxxxxxxxxxxxxxxxxxxx> <ff0b9d4e0705071759q1b46d942ydef5fa5008071764@xxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

> >      chn->state          = ECS_VIRQ;
> >      chn->notify_vcpu_id = vcpu;
> >      chn->u.virq         = virq;
> > @@ -261,14 +278,15 @@ static long evtchn_bind_ipi(evtchn_bind_
> >          ERROR_EXIT(port);
> >
> >      chn = evtchn_from_port(d, port);
> > +
> >      chn->state          = ECS_IPI;
> >      chn->notify_vcpu_id = vcpu;
> >
> >      bind->port = port;
> >
> > +    spin_unlock(&d->evtchn_lock);
> > +
> >   out:
> > -    spin_unlock(&d->evtchn_lock);
> > -
>
> This is incorrect, leaves domain locked on error path (yes, ERROR_EXIT
> is mean macro abuse!).
>
Absolutely this is a problem, when did ERROR_EXIT come about?

The patch was generated incorrectly and contains some old edits.  I
don't even mean to be touching this code region.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

xense-devel

Re: [Xen-devel][Xense-devel][PATCH][1/4] Xen Security Modules: XSM