Re: [Xen-devel] Error in XendCheckpoint: failed to flush file

[Stefan Berger <stefanb@xxxxxxxxxx>]

xen-devel-bounces@xxxxxxxxxxxxxxxxxxx wrote on 02/28/2007
01:20:15 PM:

> On 28/2/07 18:07, "Graham, Simon" <Simon.Graham@xxxxxxxxxxx>
wrote:
> 
> > OK. Do you think it's worth checking the fd type with stat and
only
> > doing the flush/fadvise if it's not a socket?
> 
> My guess is probably not. I think fsync/fadvise/lseek are all well-defined
> to fail without trashing things if passed a socket. There's no reason
to
> suspect that doing a stat() will be any quicker than just letting
the
> fsync() or fadvise() fail.
> 
> I've checked in some cleanups in this area as c/s 14176:d66dff0933.
> Hopefully it'll be in the public tree rsn, assuming I've fixed save/restore
> sufficently well!

All the xm-test that I reported that weren't working
before are working now. Thanks.

   Stefan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel