Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

RE: [Xen-devel] Error in XendCheckpoint: failed to flush file

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, "Stefan Berger" <stefanb@xxxxxxxxxx>, "xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] Error in XendCheckpoint: failed to flush file
From: "Graham, Simon" <Simon.Graham@xxxxxxxxxxx>
Date: Wed, 28 Feb 2007 11:15:29 -0500
Delivery-date: Wed, 28 Feb 2007 08:14:50 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: C20AD9F6.2F8A%Keir.Fraser@xxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1172637970.25545.5.camel@xxxxxxxxxxxxxxxxxxxxx> C20AD9F6.2F8A%Keir.Fraser@xxxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdbBqwu6tNHM8b5Edu40AAWy6hiGQAL/Kvw
Thread-topic: [Xen-devel] Error in XendCheckpoint: failed to flush file
> I'm not sure the two are related. Fsync, lseek(), fadvise() will all
> fail if
> the fd maps to a socket. The failure is harmless and the error return
> code
> is ignored. The error to xend.log is overly noisy and needs cleaning
up

Argh! Can't believe I missed these errors in my testing of the change! I
agree with Keir that they are harmless but noisy - patch to quieten
things down will follow shortly... 

Note that I thought about plumbing the live flag through to
xc_linux_restore as is done with xc_linux_save but decided I didn't want
to change the API... therefore I changed xc_linux_restore to figure out
if the fd is a socket or not... hopefully this works on Solaris??? (just
testing now).

/simgr


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel