RE: [Xen-devel] Error in XendCheckpoint: failed to flush file

To:	"Keir Fraser" <keir@xxxxxxxxxxxxx>, "Stefan Berger" <stefanb@xxxxxxxxxx>, "xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	RE: [Xen-devel] Error in XendCheckpoint: failed to flush file
From:	"Graham, Simon" <Simon.Graham@xxxxxxxxxxx>
Date:	Wed, 28 Feb 2007 13:07:25 -0500
Delivery-date:	Wed, 28 Feb 2007 10:06:45 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<C20B69A0.A58D%keir@xxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<342BAC0A5467384983B586A6B0B3767104BE106A@xxxxxxxxxxxxxxxxxxxxx> <C20B69A0.A58D%keir@xxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcdbBqwu6tNHM8b5Edu40AAWy6hiGQAL/KvwAAlrrsgAAboRYA==
Thread-topic:	[Xen-devel] Error in XendCheckpoint: failed to flush file

> Use of the live flag to gate the flush/sync calls is not a good idea.
> We can
> 'live save' to disc (checkpointing) and we can 'non-live migrate' via
a
> socket. So the live flag is not really an indicator of what the file
> descriptor maps to (file vs. socket). Best to unconditionally try the
> flush/sync and ignore errors.
> 

OK. Do you think it's worth checking the fd type with stat and only
doing the flush/fadvise if it's not a socket?

/simgr

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel