Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] [XEND] alignment of vtpm support in xenapi, docu

To: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] [XEND] alignment of vtpm support in xenapi, documentation and libxen
From: Stefan Berger <stefanb@xxxxxxxxxx>
Date: Tue, 30 Jan 2007 10:23:13 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 30 Jan 2007 07:22:57 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070130151210.GC3261@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Ewan Mellor <ewan@xxxxxxxxxxxxx> wrote on 01/30/2007 10:12:10 AM:

> On Tue, Jan 30, 2007 at 09:29:47AM -0500, Stefan Berger wrote:
>
> > This patch aligns vTPM support in the Xen-API, documentation and lib-xen
> > (after the recent changes).
> >
> > Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx>
>
> What's the intention here?  You've removed the get_instance calls, but not the
> instance field from the documentation.  Assuming that that's just a mistake,
> and you meant to remove the instance field, we're left with a VTPM class that
> has nothing other than a reference to a VM and a reference to a backend
> domain.  What are the semantics of that object now?


The instance will remain to be assigned by the hotplug scripts. In the old-style of VM configuration file one could still pass it as parameter, but its ignored. I rather not have it passed in as a parameter by the Xen-API, either. From what I can see a getter for it is not useful, either, since I want the instance number to be hidden from management software.
The instance field should then also be removed from the documentation - I forgot that.
   
Stefan

>
> Ewan.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel