RE: [Xen-devel] [PATCH 1/9] Add cpu idle pwr mgmt to xen

["Wei, Gang" <gang.wei@xxxxxxxxx>]

On Wednesday, April 30, 2008 4:54 PM, Keir Fraser wrote:
>> Thanks. Unfortunately you now use a static (but not per-CPU) variable
-
>> while I understand that it is expected that the call is done just
once, I
>> don't think this is a good thing to do.
> 
> Why is the variable even non-local? Is it just to make the
xlat_malloc*()
> interfaces simpler? It's a false simplification if so, and I think
you'd
> be better making the variable an explicit parameter to those
functions.

I was trying to make thing simple, and not aware the per_cpu issue for
global variable. Your suggestion sounds good, I will try to follow it.

> 
> Also I agree with Jan regarding non-ISO C usage of loop-header
variable
> declarations (don't do it) and also you should check
copy_from_guest*()
> return values and return -EFAULT where appropriate. His comment
regarding
> explicit padding or use of uint32_t in your public bitfield also
sounds
> good to me.

Actually, I also agree will Jan regarding the other comments. I am
revising patch for them.

Jimmy

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel