Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

RE: [Xen-devel] [PATCH 1/9] Add cpu idle pwr mgmt to xen

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH 1/9] Add cpu idle pwr mgmt to xen
From: "Wei, Gang" <gang.wei@xxxxxxxxx>
Date: Wed, 30 Apr 2008 11:27:32 +0800
Cc: Jan Beulich <jbeulich@xxxxxxxxxx>
Delivery-date: Tue, 29 Apr 2008 20:28:09 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <4815B40A.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <094BCE01AFBE9646AF220B0B3F367AAB02FE2C6E@xxxxxxxxxxxxxxxxxxxxxxxxxxxx><C4379481.1FF24%keir.fraser@xxxxxxxxxxxxx> <094BCE01AFBE9646AF220B0B3F367AAB02FE2EC4@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4815B40A.76E4.0078.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcipEbfT7gVtCqEbTvql1WxSajh7rwBXgwEA
Thread-topic: [Xen-devel] [PATCH 1/9] Add cpu idle pwr mgmt to xen
Revising done according to Jan's comments. Resend.

Jimmy

On Monday, April 28, 2008 5:25 PM, Jan Beulich wrote:
> Some comments regarding the compat guest handling: You cannot
> validly set_xen_guest_handle() on space coming from xmalloc. It is
> the purpose of the per-vCPU argument translation page to deal with
> that (i.e. the translated arguments go into that page, subject to your
> own management of how you assign space for the individual (sub-)
> hypercall's arguments).
> 
> Further, you shouldn't manually copy fields, this should be done
> through the machine generated macros in xen/include/compat/xlat.h,
> which would require you to add the structures needing translation to
> xen/include/xlat.lst.
> 
> Jan

Attachment: xen-1-cx_base-0430.patch
Description: xen-1-cx_base-0430.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel