Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

RE: [Xen-devel] [PATCH 8/9] Add cpu idle pwr mgmt to xen

To: "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>, "Jan Beulich" <jbeulich@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH 8/9] Add cpu idle pwr mgmt to xen
From: "Wei, Gang" <gang.wei@xxxxxxxxx>
Date: Tue, 29 Apr 2008 20:33:16 +0800
Cc: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 29 Apr 2008 05:33:56 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C43CB672.17F8B%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <481711A2.76E4.0078.0@xxxxxxxxxx> <C43CB672.17F8B%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acip44QowtEBDhXWEd2QpAAWy6hiGQAENLHQ
Thread-topic: [Xen-devel] [PATCH 8/9] Add cpu idle pwr mgmt to xen
On Tuesday, April 29, 2008 6:27 PM, Keir Fraser wrote:
> On 29/4/08 11:16, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
> 
>>> Most of these changes don't have any impact if no additional linux
>>> kernel parameter (xen_processor_pmbits=) was added to kernel cmdline
by
>>> Xen or manually in grub.conf. Is it still necessary to add #ifdef
>>> CONFIG_XEN even if those changes have no impact by default?
>> 
>> I would say so, but of course this is Keir's call (if he doesn't
demand
>> it, we'll have to add the respective conditionals in our fixup
patches,
>> unless it can be proven that the changes a benign for native).
> 
> I agree it's probably good practice to use #ifdef CONFIG_XEN.

Ok, I can add it and will resend the dom0 patches after gaining enough
feedbacks for them.

Jimmy

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>