Re: [Xen-devel] [PATCH 8/9] Add cpu idle pwr mgmt to xen

To:	Jan Beulich <jbeulich@xxxxxxxxxx>, Gang Wei <gang.wei@xxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH 8/9] Add cpu idle pwr mgmt to xen
From:	Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date:	Tue, 29 Apr 2008 11:26:42 +0100
Cc:	Kevin Tian <kevin.tian@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Tue, 29 Apr 2008 03:26:45 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<481711A2.76E4.0078.0@xxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	Acip44QowtEBDhXWEd2QpAAWy6hiGQ==
Thread-topic:	[Xen-devel] [PATCH 8/9] Add cpu idle pwr mgmt to xen
User-agent:	Microsoft-Entourage/11.4.0.080122

On 29/4/08 11:16, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>> Most of these changes don't have any impact if no additional linux
>> kernel parameter (xen_processor_pmbits=) was added to kernel cmdline by
>> Xen or manually in grub.conf. Is it still necessary to add #ifdef
>> CONFIG_XEN even if those changes have no impact by default?
> 
> I would say so, but of course this is Keir's call (if he doesn't demand it,
> we'll have to add the respective conditionals in our fixup patches,
> unless it can be proven that the changes a benign for native).

I agree it's probably good practice to use #ifdef CONFIG_XEN.

 -- Keir

> Jan
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel