[Xen-devel] Re: [PATCH] Re: [Xen-staging] [xen-unstable] Explici

To:	Alex Williamson <alex.williamson@xxxxxx>
Subject:	[Xen-devel] Re: [PATCH] Re: [Xen-staging] [xen-unstable] Explicitly tag every anonymous aggregate in the public headers.
From:	Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date:	Mon, 31 Mar 2008 17:21:48 +0100
Cc:	xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
Delivery-date:	Mon, 31 Mar 2008 09:23:08 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<1206978571.7735.10.camel@lappy>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AciTS1GLj/F5cv8+Edy9kgAX8io7RQ==
Thread-topic:	[PATCH] Re: [Xen-staging] [xen-unstable] Explicitly tag every anonymous aggregate in the public headers.
User-agent:	Microsoft-Entourage/11.4.0.080122

On 31/3/08 16:49, "Alex Williamson" <alex.williamson@xxxxxx> wrote:

> It seems pretty clear that in nesting __extension__ attributes in this
> manner, the struct is actually ignored and the compiler is treating the
> everything that was in the struct as a separate member of the union.  In
> the mapped_regs example, the structure size remains correct only because
> the union is full padded out using the full size arrays.  Please apply
> the patch I sent previously to revert the nested __extension__
> attributes.  Thanks,

__extension__ seems worryingly half-baked. We're better off asserting
!__STRICT_ANSI__ in my opinion. I don't suppose you much care either way as
long as ia64 boot works again. :-)

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

[Xen-devel] Re: [PATCH] Re: [Xen-staging] [xen-unstable] Explicitly tag every anonymous aggregate in the public headers., Alex Williamson

Next by Date:

Re: [Xen-devel] VMX status report. Xen: #17320 & Xen0: #500 -- no new issue, Keir Fraser

Previous by Thread:

[Xen-devel] Re: [PATCH] Re: [Xen-staging] [xen-unstable] Explicitly tag every anonymous aggregate in the public headers., Alex Williamson

Next by Thread:

[Xen-devel] Re: [PATCH] Re: [Xen-staging] [xen-unstable] Explicitly tag every anonymous aggregate in the public headers., Alex Williamson

Indexes:

[Date] [Thread] [Top] [All Lists]