 Home |
About Xen.org |
Xen |
Xen Summit |
Wiki |
Mailing List |
Bug Tracker |
Xen Downloads |
xen-devel
[Xen-devel] Re: [PATCH] Re: [Xen-staging] [xen-unstable] Explicitly tag
| To: | Alex Williamson <alex.williamson@xxxxxx> |
|---|---|
| Subject: | [Xen-devel] Re: [PATCH] Re: [Xen-staging] [xen-unstable] Explicitly tag every anonymous aggregate in the public headers. |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Fri, 28 Mar 2008 22:37:29 +0000 |
| Cc: | xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx> |
| Delivery-date: | Fri, 28 Mar 2008 15:38:33 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <1206738267.7320.43.camel@lappy> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AciRJE3KjCWe7f0XEdycwgAWy6hiGQ== |
| Thread-topic: | [PATCH] Re: [Xen-staging] [xen-unstable] Explicitly tag every anonymous aggregate in the public headers. |
| User-agent: | Microsoft-Entourage/11.4.0.080122 |
On 28/3/08 21:04, "Alex Williamson" <alex.williamson@xxxxxx> wrote:
> @@ -609,7 +609,7 @@ struct xen_ia64_opt_feature {
> unsigned long cmd; /* Which feature */
> unsigned char on; /* Switch feature on/off */
> __anonymous_union {
> - __anonymous_struct {
> + struct {
> /* The page protection bit mask of the pte.
> * This will be or'ed with the pte. */
> unsigned long pgprot;
I have no idea if it's the cause of this particular boot breakage, but I
reckon that an anonymous union containing a single anonymous struct can be
simplified. Or perhaps, if the union is there for stylistic reasons, a
single extra field in the union would fix things?
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| Previous by Date: | [Xen-devel] Re: [PATCH] Re: [Xen-staging] [xen-unstable] Explicitly tag every anonymous aggregate in the public headers., Keir Fraser |
|---|---|
| Next by Date: | Re: [Xen-devel] Re: [PATCH] Re: [Xen-staging] [xen-unstable] Explicitly tag every anonymous aggregate in the public headers., Alex Williamson |
| Previous by Thread: | [Xen-devel] Re: [PATCH] Re: [Xen-staging] [xen-unstable] Explicitly tag every anonymous aggregate in the public headers., Alex Williamson |
| Next by Thread: | Re: [Xen-devel] Re: [PATCH] Re: [Xen-staging] [xen-unstable] Explicitly tag every anonymous aggregate in the public headers., Alex Williamson |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
xen.org, 