Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

Re: [Xen-devel] linux: arch/i386/pci/irq-xen.c state

To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] linux: arch/i386/pci/irq-xen.c state
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 28 Feb 2008 16:34:42 +0000
Delivery-date: Thu, 28 Feb 2008 08:36:37 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <47C6EEAB.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ach6J9GqEA1aV+YbEdygygAX8io7RQ==
Thread-topic: [Xen-devel] linux: arch/i386/pci/irq-xen.c state
User-agent: Microsoft-Entourage/11.3.6.070618
I rather doubt it! Please send a patch to fix it up.

 -- Keir

On 28/2/08 16:26, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> Is there any reason other than it being an oversight that these two
> hunks (from patch-2.6.18.8)
> 
> diff --git a/arch/i386/pci/irq.c b/arch/i386/pci/irq.c
> index 4a8995c..65a2ce8 100644
> --- a/arch/i386/pci/irq.c
> +++ b/arch/i386/pci/irq.c
> @@ -255,13 +255,13 @@ static int pirq_via_set(struct pci_dev *router, struct
> pci_dev *dev, int pirq, i
>   */
>  static int pirq_via586_get(struct pci_dev *router, struct pci_dev *dev, int
> pirq)
>  {
> - static const unsigned int pirqmap[4] = { 3, 2, 5, 1 };
> + static const unsigned int pirqmap[5] = { 3, 2, 5, 1, 1 };
> return read_config_nybble(router, 0x55, pirqmap[pirq-1]);
>  }
>  
>  static int pirq_via586_set(struct pci_dev *router, struct pci_dev *dev, int
> pirq, int irq)
>  {
> - static const unsigned int pirqmap[4] = { 3, 2, 5, 1 };
> + static const unsigned int pirqmap[5] = { 3, 2, 5, 1, 1 };
> write_config_nybble(router, 0x55, pirqmap[pirq-1], irq);
> return 1;
>  }
> 
> is not mirrored to the Xen version of the file?
> 
> Thanks, Jan
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>