Re: [Xen-devel] xen-unstable build failure in tools/blktap/drive

To:	Kevin Wolf <kwolf@xxxxxxx>
Subject:	Re: [Xen-devel] xen-unstable build failure in tools/blktap/drivers for block-qcow2.c
From:	Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date:	Thu, 28 Feb 2008 13:02:26 +0000
Cc:	Srinivas Maturi <srinivas.maturi@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Thu, 28 Feb 2008 05:03:13 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<47C6A598.7010808@xxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	Ach6CipraPATkOX9EdyTNwAX8io7RQ==
Thread-topic:	[Xen-devel] xen-unstable build failure in tools/blktap/drivers for block-qcow2.c
User-agent:	Microsoft-Entourage/11.3.6.070618

On 28/2/08 12:14, "Kevin Wolf" <kwolf@xxxxxxx> wrote:

>> Properly speaking we should check those write() return values anyway. If we
>> don't want to deviate from the qemu original sources that much then we could
>> special-case CFLAGS to remove -Wno-unused for just that file.
> 
> Shouldn't -Wno-unused disable the check rather than enabling it?
> Removing it causes even more warnings. Maturi's compiler just seems to
> ignore that switch.
> 
> I could compile the code with both gcc 4.1.2 and 4.3.0 without any such
> problems.

Oh yes, silly me.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

xen-devel

Re: [Xen-devel] xen-unstable build failure in tools/blktap/drivers for b