Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

Re: [Xen-devel] xen-unstable build failure in tools/blktap/drivers for b

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] xen-unstable build failure in tools/blktap/drivers for block-qcow2.c
From: Kevin Wolf <kwolf@xxxxxxx>
Date: Thu, 28 Feb 2008 13:14:16 +0100
Cc: Srinivas Maturi <srinivas.maturi@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 28 Feb 2008 04:03:09 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C3EC3D06.1D279%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C3EC3D06.1D279%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.8 (X11/20060911)
> Properly speaking we should check those write() return values anyway. If we
> don't want to deviate from the qemu original sources that much then we could
> special-case CFLAGS to remove -Wno-unused for just that file.

Shouldn't -Wno-unused disable the check rather than enabling it?
Removing it causes even more warnings. Maturi's compiler just seems to
ignore that switch.

I could compile the code with both gcc 4.1.2 and 4.3.0 without any such
problems.

Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel