Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] Fix softlockup issue after vcpu hotplug

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] Fix softlockup issue after vcpu hotplug
From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
Date: Tue, 30 Jan 2007 21:12:22 +0800
Delivery-date: Tue, 30 Jan 2007 05:12:06 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C1E4F183.80AD%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdESFqDCWsISfq5RGeHgxcxVzRqmQACelaDAAAZiDAAAP4q2wADxf1QAAIpCVwAAGCUUA==
Thread-topic: [Xen-devel] [PATCH] Fix softlockup issue after vcpu hotplug
>From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx]
>Sent: 2007年1月30日 20:59
>On 30/1/07 12:11 pm, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:
>
>>> Presumably softlockup threads are killed and re-created when
>VCPUs
>>> are
>>> offlined and onlined. Perhaps the re-creation is taking a long time?
>But
>>
>> That should not be the case, since the softlockup warning continues
>> to jump out after cpu is brought online.
>
>You are confusing the two parts of the softlockup mechanism. The thread
>is
>responsible only for periodically touching the watchdog. The warning
>mechanism is driven off the timer interrupt handler. So it is entirely
>possible for warnings to appear when the thread does not exist (in fact, if
>the thread does not exist then we *expect* warnings to appear!).
>
> -- Keir

I added a debug print inside the warning by:
        printk(KERN_ERR "BUG: drift by 0x%lx\n", 
                        jiffies - touch_timestamp);

This drift doesn't increment monotonically. Most time it is about 1s 
(an interesting fact!), and seldom dozen of seconds. But anyway, it 
indicates that watchdog thread is still scheduled. :-)

Thanks,
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel