Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Bugfix: Don't use function pointers to inline fu

To: "Christoph Egger" <Christoph.Egger@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Bugfix: Don't use function pointers to inline functions
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Thu, 30 Nov 2006 12:56:30 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 30 Nov 2006 04:54:57 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200611301131.28678.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200611301131.28678.Christoph.Egger@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>There's code, which use inline functions on function pointers.
>This is IMO a bug.

I disagree - inline is a hint, not a requirement (other than one might say
about __attribute__((__always_inline__)), or when functions are declared/
defined extern inline). Hence I would expect the compiler to generate
out-of-line instances when addresses of the function are taken. Have
you brought this up with the gcc folks?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>