Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

[Xen-devel] [PATCH] Bugfix: Don't use function pointers to inline functi

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] Bugfix: Don't use function pointers to inline functions
From: "Christoph Egger" <Christoph.Egger@xxxxxxx>
Date: Thu, 30 Nov 2006 11:31:28 +0100
Delivery-date: Thu, 30 Nov 2006 02:31:53 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: AMD / OSRC
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.4
Hi!

There's code, which use inline functions on function pointers.
This is IMO a bug.

The issue has been found by gcc 4.1.1 on Gentoo Linux when compiling
a x86_64 hypervisor with -O0.
gcc link error messages are attached.

The xen_shadow.diff patch  fixes the issue.
Further, I had to move vmx_update_host_cr3() from 
xen/include/asm-x86/hvm/vmx/vmx.h to xen/arch/x86/hvm/vmx/vmx.c  or gcc 
complains in xen/arch/x86/hvm/vmx/io.c that
"vmx_update_host_cr3() is defined but not used" otherwise.

Please apply.

Attachment: link_error.txt
Description: Text document

Attachment: xen_shadow.diff
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>