[Xen-devel] [PATCH] >3 virtual nics crashes domU

[James Dykman <dykman@xxxxxxxxxx>]

Once grant refs run out, netfront prints a nice message, but doesn't set
err properly to notify the caller, and the domU crashes. (See bug 183 for
details).

Signed-off-by: Jim Dykman <dykman@xxxxxxxxxx>

diff -r e70ea9465b31 linux-2.6-xen-sparse/drivers/xen/netfront/netfront.c
--- a/linux-2.6-xen-sparse/drivers/xen/netfront/netfront.c      Thu Oct 27 
09:53:02 2005
+++ b/linux-2.6-xen-sparse/drivers/xen/netfront/netfront.c      Fri Oct 28 
12:21:01 2005
@@ -877,6 +877,7 @@
        if (gnttab_alloc_grant_references(NETIF_TX_RING_SIZE,
                                          &np->gref_tx_head) < 0) {
                printk(KERN_ALERT "#### netfront can't alloc tx grant 
refs\n");
+               err=-ENOMEM;
                goto exit;
        }
        /* A grant for every rx ring slot */
@@ -884,6 +885,7 @@
                                          &np->gref_rx_head) < 0) {
                printk(KERN_ALERT "#### netfront can't alloc rx grant 
refs\n");
                gnttab_free_grant_references(np->gref_tx_head);
+               err=-ENOMEM;
                goto exit;
        }


Jim

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel