Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xense-devel

Re: [Xen-devel] [PATCH] Intel(R) Trusted Execution Technology support

To: "Cihula, Joseph" <joseph.cihula@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>, <xense-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Intel(R) Trusted Execution Technology support
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 29 Oct 2007 17:16:57 +0000
Cc: "Xu, James" <james.xu@xxxxxxxxx>, "Wang, Shane" <shane.wang@xxxxxxxxx>, "Wei, Gang" <gang.wei@xxxxxxxxx>
Delivery-date: Mon, 29 Oct 2007 10:25:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <D936D925018D154694D8A362EEB0892002C7C0AD@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcgYPKeHAh+s/rrjQ0OzxTZHSH6adQB0Zgj0AAzUsnAAA3v0Qg==
Thread-topic: [Xen-devel] [PATCH] Intel(R) Trusted Execution Technology support
User-agent: Microsoft-Entourage/11.3.6.070618
On 29/10/07 15:38, "Cihula, Joseph" <joseph.cihula@xxxxxxxxx> wrote:

>>> Attached is a patch that adds Intel(R) Trusted Execution Technology
>>> (Intel(R) TXT) support to Xen.  Intel(R) TXT was formerly known by
> the
>>> codename LaGrande Technology (LT).
>> 
>> Seems to be missing asm-x86/tboot.h.
> 
> The build for tboot/tboot copies this file from tboot/include to
> xen/include/asm-x86.  Do you prefer that it get checked in to Xen's repo
> instead?

Okay, another issue. You can't probe for tboot by mapping and reading every
E820_RESERVED region (which is what the code you add to x86/setup.c does).
You don't know what mmio regions you could be conflicting with by making a
cacheable mapping and issuing memory reads (which can have side effects when
issued to I/O devices).

Why is the memory region not marked as E820_UNUSABLE by tboot? And/or extend
the multiboot info structure and transmit the address of the shared page
that way.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>