Re: [Xen-devel] Re: [Xense-devel] [XSM:ACM][PATCH] nulldereference bug fix

["Coker, George" <gscoker@xxxxxxxxxxxxxx>]

This patch is correct for XSM.  The patch creates clean
acm_domain_create and acm_domain_destroy operations.

In 15661 the logic under which acm_domain_destroy is called is slightly
different than under XSM.  In 15661, acm_domain_destroy is called only
if the mask INIT_acm is set.  INIT_acm is set only on successful return
from acm_domain_create.  When acm_domain_create fails, the mask is not
set and acm_domain_destroy is not called.  I do not know if this
resulted in a leak in 15661 due to incomplete cleanup.

George


On Thu, 2007-09-27 at 14:35 -0400, Stefan Berger wrote:
> 
> xense-devel-bounces@xxxxxxxxxxxxxxxxxxx wrote on 09/27/2007 12:43:35
> PM:
> 
> > The attached patch fixes a null dereference bug in XSM:ACM. 
> 
> As I read this in response to recent error reports - I wonder why CS
> 15661 does not expose this error whereas afterwards this error occurs.
> Are you sure this is the right solution? Was something changed in this
> area of the code between 'before XSM' and afterwards? 
> 
>    Stefan 
> 
> 
> 
> > 
> > Signed-off-by: George Coker <gscoker@xxxxxxxxxxxxxx>
> > [attachment "acm-xsm-null_bug-092707-xen-unstable-15880.diff" 
> > deleted by Stefan Berger/Watson/IBM] 
> > _______________________________________________
> > Xense-devel mailing list
> > Xense-devel@xxxxxxxxxxxxxxxxxxx
> > http://lists.xensource.com/xense-devel
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
-- 
George S. Coker, II <gscoker@xxxxxxxxxxxxxx> 443-479-6944

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel