Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xense-devel

Re: [Xen-devel] Re: [Xense-devel] [XSM:ACM][PATCH] nulldereference bug f

To: "George S. Coker, II" <gscoker@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [Xense-devel] [XSM:ACM][PATCH] nulldereference bug fix
From: Stefan Berger <stefanb@xxxxxxxxxx>
Date: Fri, 28 Sep 2007 11:20:58 -0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xense-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 28 Sep 2007 08:21:45 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1190991927.3729.119.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

[...]
> > > >
>
> Ok, but then the null dereference issue still exists within the context
> of XSM.  The options are:
>
> 1) Follow acm_free_domain_ssid(d->ssid) with d->ssid = NULL
> (I've tested this and it maintains the desired policy state:
>
> Confict Sets:
>
>    c-set 0:    00 01 00 01
>
> Running
> Types:         01 01 00 00
>
> Conflict
> Aggregate Set: 00 00 00 01
>
> but seems less attractive from a coding style perspective)
>
> or
>
> 2) Chance acm_free_domain_ssid to pass d instead of ssid and ensure that
> d->ssid = NULL in acm_free_domain_ssid.


Sounds like this is cleaner and so I opt for this choice.

   Stefan

>
> George
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel