Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xense-devel

Re: [Xen-devel][Xense-devel][PATCH][3/4] Xen Security Modules: tools

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel][Xense-devel][PATCH][3/4] Xen Security Modules: tools
From: Mark Williamson <mark.williamson@xxxxxxxxxxxx>
Date: Tue, 8 May 2007 10:40:23 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, "George S. Coker, II" <gscoker@xxxxxxxxxxxxxx>, xense-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 08 May 2007 02:39:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C265E1E1.6F8A%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C265E1E1.6F8A%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.6
> There are two styles we properly support: Xen style as in files like
> event_channel.c, xmalloc.c, etc.; and Linux style (generally seen in files
> ripped off fairly directly from Linux -- *not* used in new files). The
> halfway-house files usually arise from me having been too lazy to enforce
> Xen style when they were checked in, and generally being in bits of the
> tree where I don't often venture.

I did wonder if it was something like that ;-)

> Seeing as we're planning to be more strict from now on, the current ACM
> code style is *not* to be followed.

Cool, thanks for the clarification.  I'll continue running the verifier over 
new patches and I can submit it for inclusion in 3.0.6 - once I've finished 
teaching it the difference between Xen and Linux.  Then folks will be able to 
run it over submitted code as a sanity test.

Cheers,
Mark

-- 
Dave: Just a question. What use is a unicyle with no seat?  And no pedals!
Mark: To answer a question with a question: What use is a skateboard?
Dave: Skateboards have wheels.
Mark: My wheel has a wheel!

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel