[Xen-devel] Re: [PATCH] choose security model for ACM at built-time

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 24 Jun 2005, at 16:33, aq wrote:

> At the moment, there is a problem with ACM: it is impossible to set
> ACM security model at built-time, so even with ACM is chosen to build,
> the default policy is NULL, which is useless.
>
> This patch propose a solution to this problem: build process will
> generate a header file (include/public/acm_policy.h) based on the
> value set in xen/Makefile or at command-line, and gets acm.h included
> it.
Looks fine, but:

Firstly, is the configured policy something that needs to be propagated 
to user tools (i.e., should the generated header reside within 
include/public or should it be in include/xen)?
Secondly, you missed conditional inclusion of acm/acm.o into the 
ALL_OBJS list in xen/Rules.mk. Also, the definition of 
ACM_USE_SECURITY_POLICY probably belongs more correctly in Rules.mk 
rather than the Makefile.
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel