Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xense-devel

[Xen-devel] [RFC] Cleaning up SCM debug

To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, xense-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [RFC] Cleaning up SCM debug
From: Anthony Liguori <aliguori@xxxxxxxxxx>
Date: Wed, 22 Jun 2005 22:20:12 -0500
Delivery-date: Thu, 23 Jun 2005 03:19:21 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.2 (X11/20050317)
Hi,

public/acm.h defines both an ACM_DEBUG flag and a printkd function that, if ACM_DEBUG is defined will convert to a printk. public/acm.h is included by userspace applications where printk isn't necessarily meaningful. Furthermore, it appears ACM_DEBUG is only used within Xen anyway so making it apart of the public headers doesn't make much sense.

Therefore, I'd like to move ACM_DEBUG and printkd into acm/acm_core.h. While at it, it seems like a good idea to change the printkd into either one of the existing Xen debug macros or to get rid of it altogether.

I wanted to check first to see if there was an emerging standard macro (a quick glance shows printk, DPRINTK, PRINT, and I'm sure there are at least a few more). Recommendations are appreciated.

Regards,

Anthony Liguori

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>