Re: [Xen-users] Credit Scheduler!

[Emmanuel Ackaouy <ack@xxxxxxxxxxxxx>]

On Fri, Jun 30, 2006 at 09:49:57AM -0500, Hardeep Singh wrote:
>    root@pippin:/home/hardeep# xm sched-credit -d vm1 -w 10
> 
>    (XEN) BUG at sched_credit.c:757

Ok I found the problem and submitted a fix to the staging
tree. It should trickle out to the public tree in a couple
hours when it's gone through the regression tests.

In the meantime, here's a patch if you don't want to wait.

diff -r 3dfc2583a4f1 xen/common/sched_credit.c
--- a/xen/common/sched_credit.c Thu Jun 29 16:59:47 2006 +0100
+++ b/xen/common/sched_credit.c Fri Jun 30 16:56:17 2006 +0100
@@ -622,9 +622,12 @@ csched_dom_cntl(
 
         if ( cmd->u.credit.weight != 0 )
         {
-            csched_priv.weight -= sdom->weight;
+            if ( !list_empty(&sdom->active_sdom_elem) )
+            {
+                csched_priv.weight -= sdom->weight;
+                csched_priv.weight += cmd->u.credit.weight;
+            }
             sdom->weight = cmd->u.credit.weight;
-            csched_priv.weight += sdom->weight;
         }
 
         if ( cmd->u.credit.cap != (uint16_t)~0U )

_______________________________________________
Xen-users mailing list
Xen-users@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-users