Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [PATCH] fix PAL call in physical mode.

To: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] [PATCH] fix PAL call in physical mode.
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Wed, 20 Aug 2008 18:38:59 +1000
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 20 Aug 2008 01:39:04 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20080820072547.GF31719%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20080820063907.GA15445@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20080820065751.GB4597@xxxxxxxxxxxx> <20080820072547.GF31719%yamahata@xxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Aug 20, 2008 at 04:25:47PM +0900, Isaku Yamahata wrote:
> On Wed, Aug 20, 2008 at 04:57:53PM +1000, Simon Horman wrote:
> > On Wed, Aug 20, 2008 at 03:39:07PM +0900, Isaku Yamahata wrote:
> > > [IA64] fix PAL call in physical mode.
> > > 
> > > Now firmware code is mapped at its own virtual address space
> > > which is same to Linux. So the calculation from virutal 
> > > address to physical address should be same to the linux one.
> > > In practice firmware is located in low physical address area
> > > so that masking 60 bit instead of 61 bits doesn't make difference.
> > 
> > Can't we just get rid of #ifdef XEN ?
> > And possibly even move pal.S back into xen/arc/ia64/linux/ ?
> > 
> > I just checked and with the patch below,
> > xen/arch/ia64/linux-xen/pal.S becomes the same as
> > arch/ia64/kernel/pal.S from linux 2.6.21.
> 
> Great. Moving back pal.S sounds a good idea.
> 
> [IA64] move back pal.S into xen/arch/ia64/linux.
> 
> Now xen/arch/ia64/linux-xen/pal.S is the same as
> arch/ia64/kernel/pal.S from linux 2.6.21.
> So move it back into xen/arch/ia64/linux.
> 
> Signed-off-by: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>

Acked-by: Simon Horman <horms@xxxxxxxxxxxx>

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>