Re: [Xen-devel] xend: Better support for legacy HVM config of ia

To:	KUWAMURA Shin'ya <kuwa@xxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] xend: Better support for legacy HVM config of ia64
From:	Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date:	Mon, 11 Aug 2008 11:28:52 +0100
Cc:	xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Mon, 11 Aug 2008 03:29:20 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<C4C5CBB4.2549E%keir.fraser@xxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	Acj7mLpY+S7vSGeLEd2BigAX8io7RQABFJBY
Thread-topic:	[Xen-devel] xend: Better support for legacy HVM config of ia64
User-agent:	Microsoft-Entourage/11.4.0.080122

On 11/8/08 10:57, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:

>> On ia64, direct Linux boot is not supported, and 'Flash.fd' or
>> 'guest_firmware.bin' has been used as a value of the 'kernel'
>> option. Cset:17016 ignores those strings and overrides them with
>> "/usr/lib/xen/boot/hvmloader".
>> 
>> We tested on x86_64 and ia64 with old and new configs.
>> 
>> Signed-off-by: Kazuhiro Suzuki <kaz@xxxxxxxxxxxxxx>
>> Signed-off-by: KUWAMURA Shin'ya <kuwa@xxxxxxxxxxxxxx>
> 
> Conditionally clearing 'PV_kernel' after copying it into 'loader' seems odd.
> Would you ever want to keep the 'PV_kernel' option when it doesn't contain
> the string 'hvmloader'?

I applied a simplified version of your patch (actually a one-liner!) as
changeset 18306. Let me know if it doesn't do what you require.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

xen-ia64-devel

Re: [Xen-devel] xend: Better support for legacy HVM config of ia64