Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-ia64-devel

RE: [Xen-ia64-devel] [Xen-ia64][PATCH] Fix NVRAM data can notbesaved whe

To: "Zhang, Xing Z" <xing.z.zhang@xxxxxxxxx>, "Alex Williamson" <alex.williamson@xxxxxx>
Subject: RE: [Xen-ia64-devel] [Xen-ia64][PATCH] Fix NVRAM data can notbesaved when guest execute "reboot" instruction
From: "Zhang, Xing Z" <xing.z.zhang@xxxxxxxxx>
Date: Thu, 28 Jun 2007 17:00:06 +0800
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 28 Jun 2007 01:58:07 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ace5N/YbOJSMtfZ1R5S4C5rS5BrdpQAB0DZQAATo+BAAA+mg8A==
Thread-topic: [Xen-ia64-devel] [Xen-ia64][PATCH] Fix NVRAM data can notbesaved when guest execute "reboot" instruction
Hi Alex:
        This is new one per you comments. It also fixes NVRAM save when execute 
"xm reboot" in Xend

>-----Original Message-----
>From: Zhang, Xing Z
>Sent: 2007年6月28日 15:07
>To: Zhang, Xing Z; 'Alex Williamson'
>Cc: 'xen-ia64-devel@xxxxxxxxxxxxxxxxxxx'
>Subject: RE: [Xen-ia64-devel] [Xen-ia64][PATCH] Fix NVRAM data can notbesaved
>when guest execute "reboot" instruction
>
>>>definitely the obvious candidate, but we could also make it an
>>>architecture dependent static inline in something like vl.h, where the
>>>overloading occurs now.  The overloading is a nice trick, but a context
>>>dependent function like that seems prone to errors to me.  Thanks,
>>[Wing] You may misunderstand my means. Yes, we can implement a hook in vl.h
>as
>>an inline function. But the hook must call the function 
>>xc_ia64_save_to_nvram()
>>which implemented in xc_ia64_hvm_build.c. And the hook is called by
>>xc_domain_shutdown() which in xc_domain.c. So xc_domain_shutdown() belongs to
>>libxenctrl.so while xc_ia64_save_tonvram() belongs to libxenguest.so.
>>
>>A way is move all NVRAM related functions to libxenctrl.so
>[Wing] I am sorry, it's my misunderstanding. I will redo the patch and send out
>it later.

Attachment: nvram_reboot_fix.patch
Description: nvram_reboot_fix.patch

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel
<Prev in Thread] Current Thread [Next in Thread>