RE: [Xen-ia64-devel] [Xen-ia64][PATCH] Fix NVRAM data can notbesaved when guest execute "reboot" instruction

["Zhang, Xing Z" <xing.z.zhang@xxxxxxxxx>]

>   Why must the hook be implemented in xc_ia64_hvm_build.c?  It's
>definitely the obvious candidate, but we could also make it an
>architecture dependent static inline in something like vl.h, where the
>overloading occurs now.  The overloading is a nice trick, but a context
>dependent function like that seems prone to errors to me.  Thanks,
[Wing] You may misunderstand my means. Yes, we can implement a hook in
vl.h as an inline function. But the hook must call the function
xc_ia64_save_to_nvram() which implemented in xc_ia64_hvm_build.c. And
the hook is called by xc_domain_shutdown() which in xc_domain.c. So
xc_domain_shutdown() belongs to libxenctrl.so while
xc_ia64_save_tonvram() belongs to libxenguest.so.

A way is move all NVRAM related functions to libxenctrl.so 

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel