[Xen-ia64-devel] Re: [patch] more Xenification of sn2 irq code

[Alex Williamson <alex.williamson@xxxxxx>]

Jes,

   This first chunk seems to serve no purpose other than to cause
'defined but not used' warnings in the build.  I must have forgotten to
use no_warns=y before committing it.  Can we leave these ifdef'd out
until you actually use them?  Thanks,

        Alex

On Tue, 2007-06-19 at 09:37 +0200, Jes Sorensen wrote:
> diff -r 6acbcc850000 -r f5c03237a7f0 
> xen/arch/ia64/linux-xen/sn/kernel/io_init.c
> --- a/xen/arch/ia64/linux-xen/sn/kernel/io_init.c       Mon Jun 18 17:04:56 
> 2007 +0200
> +++ b/xen/arch/ia64/linux-xen/sn/kernel/io_init.c       Tue Jun 19 09:35:38 
> 2007 +0200
> @@ -182,6 +182,7 @@ sn_pcidev_info_get(struct pci_dev *dev)
>         }
>         return NULL;
>  }
> +#endif
>  
>  /* Older PROM flush WAR
>   *
> @@ -361,6 +362,7 @@ sn_pci_window_fixup(struct pci_dev *dev,
>         controller->window = new_window;
>  }
>  
> +#ifndef XEN
>  void sn_pci_unfixup_slot(struct pci_dev *dev)
>  {
>         struct pci_dev *host_pci_dev = SN_PCIDEV_INFO(dev)->host_pci_dev;
> @@ -656,9 +658,7 @@ static int __init sn_io_early_init(void)
>  static int __init sn_io_early_init(void)
>  {
>         int i, j;
> -#ifndef XEN
>         struct pci_dev *pci_dev = NULL;
> -#endif
>  
>         if (!ia64_platform_is("sn2") || IS_RUNNING_ON_FAKE_PROM())
>                 return 0; 
-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel