Re: [Xen-devel] [RFC][PATCH] domheap optimization for NUMA

To:	"Zhai, Edwin" <edwin.zhai@xxxxxxxxx>, <ryanh@xxxxxxxxxx>
Subject:	Re: [Xen-devel] [RFC][PATCH] domheap optimization for NUMA
From:	Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date:	Mon, 31 Mar 2008 11:47:36 +0100
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Mon, 31 Mar 2008 03:48:57 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<20080331104015.GM18363@xxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AciTHKGf4GaMsv8PEdy9kgAX8io7RQ==
Thread-topic:	[Xen-devel] [RFC][PATCH] domheap optimization for NUMA
User-agent:	Microsoft-Entourage/11.4.0.080122

On 31/3/08 11:40, "Zhai, Edwin" <edwin.zhai@xxxxxxxxx> wrote:

> A new interface alloc_domheap_pages_on_node is introduced instead of changing
> current implementation, which is invasive.
> 
> There are still many places left for the new interface, but we can change them
> in a incremental way if needed.

A function called alloc_domheap_pages_on_node() should take a *node*
argument not a vcpu. Perhaps have a helper domain_default_node() which
returns node for d->vcpu[0] if d->vcpu[0] is non-NULL, else returns some
value meaning 'any'.

This will probably require some changes to page_alloc.c. That file currently
likes to pass cpu ids around rather than node ids, but it would really be
cleaner to pass around the latter.

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel