[Xen-devel] Re: [PATCH 2/4] extract vmcoreinfo from /proc/vmcore for Xen

[Itsuro ODA <oda@xxxxxxxxxxxxx>]

Hi,

On Mon, 31 Mar 2008 15:51:30 +0900
Akio Takebe <takebe_akio@xxxxxxxxxxxxxx> wrote:

> Hi, Itsuro
> 
> >--- include/xen/interface/kexec.h.org        2008-03-25 09:08:43.000000000 
> >+0900
> >+++ include/xen/interface/kexec.h    2008-03-25 09:12:02.000000000 +0900
> >@@ -111,6 +111,10 @@
> > #define KEXEC_RANGE_MA_CRASH 0   /* machine address and size of crash area 
> > */
> > #define KEXEC_RANGE_MA_XEN   1   /* machine address and size of Xen itself 
> > */
> > #define KEXEC_RANGE_MA_CPU   2   /* machine address and size of a CPU note 
> > */
> >+#define KEXEC_RANGE_MA_VMCOREINFO   3   /* machine address and size of 
> >vmcoreinfo */
> >+
> >+extern size_t vmcoreinfo_max_size_xen;
> Why don't you use VMCOREINFO_BYTES (4096) instead of vmcoreinfo_max_size_xen?

There is no significant reason now. Just reserve the posibility
to make it variable.

Thanks.
-- 
Itsuro ODA <oda@xxxxxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel