Re: [Xen-devel] grant tables and HVM+PV

To:	John Levon <levon@xxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] grant tables and HVM+PV
From:	Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date:	Fri, 28 Mar 2008 17:03:17 +0000
Delivery-date:	Fri, 28 Mar 2008 10:04:40 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<20080328165022.GA21681@xxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AciQ9Z3d3CUbL/zoEdyMEAAX8io7RQ==
Thread-topic:	[Xen-devel] grant tables and HVM+PV
User-agent:	Microsoft-Entourage/11.4.0.080122



On 28/3/08 16:50, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote:

> Has broken our HVM PV drivers. Previously we were using:
> 
> 520         if ((HYPERVISOR_grant_table_op(GNTTABOP_setup_table, pset, 1) !=
> 0) ||
> 521             (pset->status != 0)) {
> 
> even on HVM. Now, this isn't actually necessary (stuff works fine with
> the call nop'd out, presumably due to the auto-sizing), but I wonder why the
> only grant op allowed is _query_size? IE what's the status of grant
> table code on HVM/PV? Is it just disabled because no compat audit has
> been done, or what?

Most of the mapping calls wouldn't work at all. Query_size() could probably
be simply given a stub implementation for HVM that returns all is good.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel