Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

[Xen-devel] [PATCH] Remove duplicate setResume()

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] Remove duplicate setResume()
From: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
Date: Thu, 28 Feb 2008 18:54:13 +0900
Delivery-date: Thu, 28 Feb 2008 01:55:02 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi,

I found two setResume()s in XendDomainInfo.py. 
One or the other is not necessary, is it? 

# grep -n -A 2 setResume ./tools/python/xen/xend/XendDomainInfo.py 
1394:    def setResume(self, isresume):
1395-        self._resume = isresume
1396-
--
1409:    def setResume(self, state):
1410-        self._resume = state
1411-

Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

Best regards,
 Kan

diff -r 2a8eaba24bf0 tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py   Tue Feb 26 15:11:51 2008 +0000
+++ b/tools/python/xen/xend/XendDomainInfo.py   Thu Feb 28 18:27:49 2008 +0900
@@ -1406,9 +1406,6 @@ class XendDomainInfo:
     def setWeight(self, cpu_weight):
         self.info['vcpus_params']['weight'] = cpu_weight
 
-    def setResume(self, state):
-        self._resume = state
-
     def getRestartCount(self):
         return self._readVm('xend/restart_count')
 

Attachment: remove_setResume.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] Remove duplicate setResume(), Masaki Kanno <=