Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Fix c/s 17104

To: Christoph Egger <Christoph.Egger@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix c/s 17104
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 25 Feb 2008 09:03:18 +0000
Delivery-date: Mon, 25 Feb 2008 01:03:44 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200802250922.08405.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ach3jUMbgXei1eOAEdysaAAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] Fix c/s 17104
User-agent: Microsoft-Entourage/11.3.6.070618
Nice one. I didn't have a good coding afternoon on Friday. :-(

In general the mmio (and other) emulation changes have had very little
testing on AMD, so please do test and let me know if anything else has
broken.

 -- Keir

On 25/2/08 08:22, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> 
> Hi Keir,
> 
> Changeset 17104 does not look correct to me.
> svm_set_interrupt_shadow() seems to be a copy & paste bug, because
> the intr_shadow parameter is unused.
> I think, what you intended to do is the attached patch.
> That's all what I found so far just from reading the diff - but there may be
> more. Please double-check.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>