Re: [Xen-devel][PATCH][ioemu] strip tap subtype prefix from imag

On Wednesday 30 January 2008 15:45:03 Keir Fraser wrote:
> On 30/1/08 14:38, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
> >>   out:
> >> +    free(drv);
> >> +    free(buf);
> >> +    free(bpath);
> >>      free(image);
> >>      free(vec);
> >
> > That doesn't work. If strdup() fails, then drv and buf are NULL here.
> > Analagous counts for the other failures.
> > You need to check for != NULL before calling free().
>
> free() is defined to accept a NULL argument.
>
>  -- Keir

That's right. But that is the way to get in double-free() security holes.

Christoph

-- 
AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

[Xen-ia64-devel] [PATCH] Fix xm shutdown/reboot for HVM domain of IA64, Masaki Kanno

Next by Date:

Re: [Xen-devel][RFC] Dynamic modes support for PV xenfb (included), Markus Armbruster

Previous by Thread:

Re: [Xen-devel][PATCH][ioemu] strip tap subtype prefix from image name (restyled), Keir Fraser

Next by Thread:

Re: [Xen-devel][PATCH][ioemu] strip tap subtype prefix from image name (restyled), Pat Campbell

Indexes:

[Date] [Thread] [Top] [All Lists]