Re: [Xen-devel][PATCH][ioemu] strip tap subtype prefix from image name

["Christoph Egger" <Christoph.Egger@xxxxxxx>]

On Wednesday 30 January 2008 13:57:24 Pat Campbell wrote:
> Currently I am not able to mount or boot from an HVM CDROM when it is
> configured for 'tap:aio' instead of 'file'.
>
> disk=[ 'tap:aio:/var/lib/xen/images/sles10-sp2-fv/disk0,hda,w', '
>        tap:aio:/home/iso/sles/SLES10.iso,hdc:cdrom,r', ]
>
> With the attached patch I am able to boot from the CDROM and or mount it.
>
> Patch changes xenstore.c:xenstore_process_event() to strip the tap subtype
> prefix from the image name.
>
> Please apply to xen-unstable tip.
>
> Signed-off-by: Pat Campbell <plc@xxxxxxxxxx>

Please use a more readable coding style.

What you did is this:

if (a) {
        if (b) {
                if (c) {
                        /* do it */
                } else {
                        /* Alternative C */
                } 
        } else {
                /* Alternative B */
        }
} else {
        /* Alternative A */
}
return;



I suggest you to use this style:

if (!a) {
    /* Alternative A */
    return;
}
if (!b) {
    /* Alternative B */
    return;
}
if (!c) {
    /* Alternative C */
    return;
}
/* do it */
return;



-- 
AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel