Re: [Xen-devel] 3.1.x and 3.2.x releases

To:	"John Levon" <levon@xxxxxxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] 3.1.x and 3.2.x releases
From:	"Ryan Scott" <rjscott@xxxxxxxxx>
Date:	Fri, 28 Dec 2007 20:18:21 -0500
Cc:	caglar@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Fri, 28 Dec 2007 17:18:40 -0800
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:references; bh=55H/z+l5vYttb9bWz/t7fF+pyNRLn7YQwL2s/DGPu3M=; b=Brpm9XsWISHBpPBh/yNrH6ov/ZJumQ9HlEhncumJe3oVfYwfZyguFEn4Qp9Ft2GFPWNwztSbkaNfo2tLz3mAJ2QFd0ySSusMVAOZpYJSCPlrNy4wkh1r+X8iw93ryFXnGB5L4ed272N3nWssbl6cw7Nkjh6JnEWCJ6eo60ON1vE=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:references; b=K3O5LpnJh7j0I6SUfQexWJyYGv+E/MNrb3PovSsns3wQE9x16zQ8PP/7DfGJpSyjRJwnXdHHRdbp8SZApOj8gUAz2FErojKCTlF9KqrTKN4Ax6H/qqUMIC89xbXSWy8trsEq0A0xfDw7kbBe5b0kfQhxWhnhAOFwlk17cyA1hM8=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<20071228145540.GA8404@xxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<200712281217.11561.caglar@xxxxxxxxxxxxx> <C39AA7C2.1196A%Keir.Fraser@xxxxxxxxxxxx> <20071228145540.GA8404@xxxxxxxxxxxxxxxxxxxxxxx>
Reply-to:	ryan.scott@xxxxxxx
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On Dec 28, 2007 9:55 AM, John Levon <levon@xxxxxxxxxxxxxxxxx> wrote:

On Fri, Dec 28, 2007 at 01:16:50PM +0000, Keir Fraser wrote:

> Oh, it's because your stdint.h type definitions are macros rather than
> typedefs. I believe the C spec requires them to be typedef names (Section
> 7.18 of the C99 draft spec). It looks like the problem stems from the
> stdint.h supplied with gnulib, included in libvirt-0.4.0. Why does libvirt
> require its own stdint.h?

Note this same bogus header breaks Solaris full stop (I think we have a
patch for it, but I'm not sure)

I did hit this when compiling 0.4.0 on Solaris. I hacked around this with the following patch, but figured I'd spend more time figuring out a better solution before sending something upstream. Still, it may be useful to some.

-Ryan

diff --git a/configure b/configure
--- a/configure
+++ b/configure
@@ -36255,7 +36255,7 @@ fi
CFLAGS="$old_cflags"
LDFLAGS="$old_ldflags"

-GNUTLS_CFLAGS=
+GNUTLS_CFLAGS=-D_GL_JUST_INCLUDE_SYSTEM_STDINT_H
GNUTLS_LIBS=
if test "x$PKG_CONFIG" != "x" ; then

diff --git a/proxy/Makefile.in b/proxy/Makefile.in
--- a/proxy/Makefile.in
+++ b/proxy/Makefile.in
@@ -154,7 +154,7 @@ BITSIZEOF_WINT_T = @BITSIZEOF_WINT_T@
BRCTL = @BRCTL@
CC = @CC@
CCDEPMODE = @CCDEPMODE@
-CFLAGS = @CFLAGS@
+CFLAGS = @CFLAGS@ -D_GL_JUST_INCLUDE_SYSTEM_STDINT_H
COMPILER_FLAGS = @COMPILER_FLAGS@
COVERAGE_CFLAGS = @COVERAGE_CFLAGS@
COVERAGE_LDFLAGS = @COVERAGE_LDFLAGS@

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel