Re: [Xen-devel] [PATCH] Fix xend xenstore handling

On Fri, Dec 21, 2007 at 02:57:26PM +0000, John Levon wrote:
> 
> This is the cause of the "reboot loop" xend failures I reported earlier.
> Note that I've only tested this patch against 3.1, however the code,
> and the fix, is the same in unstable. I realise it's late in the cycle
> but this bug is bad enough to need fixing IMHO.

I think the entire code segment from the point at which xstransact() is
created needs to be in a try...finally   block to be safe against the
code throwing exceptions, otherwise you could very ocassionally get the
final xs.abort() being missed in error conditions.

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

[Xen-devel] One potential issue of shadow fault emulation, Jiang, Yunhong

Next by Date:

Re: [Xen-devel] [PATCH] Fix xend xenstore handling, John Levon

Previous by Thread:

[Xen-devel] [PATCH] Fix xend xenstore handling, John Levon

Next by Thread:

Re: [Xen-devel] [PATCH] Fix xend xenstore handling, John Levon

Indexes:

[Date] [Thread] [Top] [All Lists]