Re: [Xen-devel] [PATCH] Create XEN_DOMCTL_set_opt_feature

To:	Alex Williamson <alex.williamson@xxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] Create XEN_DOMCTL_set_opt_feature
From:	Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date:	Wed, 28 Nov 2007 17:39:31 +0000
Cc:	xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Wed, 28 Nov 2007 09:40:53 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<1196271074.7687.24.camel@lappy>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	Acgx5aGw4FDp153YEdyqDgAX8io7RQ==
Thread-topic:	[Xen-devel] [PATCH] Create XEN_DOMCTL_set_opt_feature
User-agent:	Microsoft-Entourage/11.3.6.070618

On 28/11/07 17:31, "Alex Williamson" <alex.williamson@xxxxxx> wrote:

>    This patch goes along with the guest_os_type domain config patch.
> Once we know what the guest OS is in the builder code, we need a
> mechanism to set optimization features for that guest.  This is done via
> a new XEN_DOMCTL as shown in the patch below.  This only has ia64
> specific contents at the moment, but could be expanded for x86.  I
> expect the contents of the structure will mostly be architecture
> specific.  Thanks,

If you use this in the builder, why do you need a hvm param at all? In any
case I don't like the encoding of OS strings into hvm_param integers. Either
the concept of 'OS type' should not be visible to Xen, or a proper
enumeration should be defined, or if you want a string then the builder
should stick it in memory for your virtual boot firmware to pick up.

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel