Re: [Xen-devel] [PATCH][HVM] fix migration from NX-capable machi

To:	"Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH][HVM] fix migration from NX-capable machine to non-NX-capable machine
From:	"Dave Lively" <dlively@xxxxxxxxxxxxxxx>
Date:	Fri, 28 Sep 2007 09:22:34 -0400
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Fri, 28 Sep 2007 06:23:13 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=qyW2iUbqYf/uGV3N0iDtYafwEEZfCKqawMcE4o1n6CI=; b=GcTTcrX6Qj68VmZ0tEvhsMcHgN4AMXHVs3bRRd4MOv85eu2jBFl9zVWE9+h6kygJmI9LEgCDr68/165DnsOX2N31wAiH8j4+YNYGOasx3nrAQr7PlZPtcnx8CHBCzvo9dh27fulh+AnXUU2pHxOyPIZfimO1KgaHzNK7IgU2XTk=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=gWTM31dzqA8cDuvCTdbRvyn98kIct75Y4IpYrPQW3Az7lz4VzS3jJCJsCx9Jt5gsJqvHC2h6C+cgbHvBvWjKVukSdiz08Q0xBjZo3goqBAQOqULHu0eGcqYPf1hKO4U4nrAZ5Z8+AriWMZFHcC3KRxx8jrjFxzs9GauBqWG98Xk=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<C32264B7.E23F%Keir.Fraser@xxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<46FC1CD4.6030905@xxxxxxxxxxxxxxx> <C32264B7.E23F%Keir.Fraser@xxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 9/28/07, Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> wrote:
> On 27/9/07 22:12, "David Lively" <dlively@xxxxxxxxxxxxxxx> wrote:
> > +    u64 efer_mask = EFER_SCE || (cpu_has_nx ? EFER_NX : 0);
>
> Wrong kind of OR?

Ack.  Yes, thank you.  It was "working" because EFER_SCE == 1, so
efer_mask was always 1, but this meant I was never propagating EFER_NX
....  I'll retest with '|' and get back to you.

> As for AMD, are there any SVM CPUs that do not also support NX?

I saw this bug on an Intel CPU that supported NX -- it was just
disabled in the BIOS.  I'll be speaking with some AMD folks later this
morning, so I'll ask whether the same thing is possible w/AMD SVM.

Dave

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

xen-devel

Re: [Xen-devel] [PATCH][HVM] fix migration from NX-capable machine to no