Re: [Xen-devel] [PATCH][SVM] HVM fix for SWINT event injection

To:	"Woller, Thomas" <thomas.woller@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH][SVM] HVM fix for SWINT event injection
From:	Keir Fraser <keir@xxxxxxxxxxxxx>
Date:	Tue, 31 Jul 2007 19:02:53 +0100
Delivery-date:	Tue, 31 Jul 2007 11:00:47 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<683860AD674C7348A0BF0DE3918482F605801BE9@xxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcfQYzPKvOx6lNgtT0G0uq8JV8aZRwAA5lXuAJrKr0AAB0EbsQAllg0AAAXr02c=
Thread-topic:	[Xen-devel] [PATCH][SVM] HVM fix for SWINT event injection
User-agent:	Microsoft-Entourage/11.3.3.061214

On 31/7/07 16:30, "Woller, Thomas" <thomas.woller@xxxxxxx> wrote:

>> What I'll do is reorder SVM's intr.c core code to be the same
>> as for VMX (it's currently bogusly different) but with the
>> added constraint that we do not propagate exitintinfo.swint
>> into eventinj. I'll add a comment to explain why.
> Ok. Shoot me the patch first if you have time, I'll test with all the
> HVM guests I have on hand.

http://xenbits.xensource.com/staging/xen-unstable.hg, changeset 15662. It's
rather large, and only run-tested on VT. :-) I'll try and do some SVM
testing at home, but it'd be great if you can give it a spin.

My only question is whether vmcb->exitintinfo is written on every vmexit,
even those where no event was being delivered. I assumed so, and hence do
not bother to zap the field before vmentry, but that'll need adding back in
if I'm wrong.

> Re: 15652
> 15658 looks good initially, appreciate the quick fixes.

Yes, that was an embarrassing bug and not in Eric Liu's original patch!

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel