RE: [Xen-devel] compile error of HVM pv drivers

["Zhao, Yunfeng" <yunfeng.zhao@xxxxxxxxx>]

The problem may be from the new changes in 
unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h

the following two lines:
#define netif_tx_lock_bh(dev) (spin_lock_bh(&(dev)->xmit_lock))
#define netif_tx_unlock_bh(dev) (spin_unlock_bh(&(dev)->xmit_lock))
should be
#define netif_tx_lock_bh(dev) (spin_lock_bh(&dev->xmit_lock))
#define netif_tx_unlock_bh(dev) (spin_unlock_bh(&dev->xmit_lock))
"()" is useless for dev.

Thanks
Yunfeng



>-----Original Message-----
>From: Keir Fraser [mailto:keir@xxxxxxxxxxxxx]
>Sent: 2007年7月30日 22:52
>To: Kieran Mansley; Zhao, Yunfeng
>Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
>Subject: Re: [Xen-devel] compile error of HVM pv drivers
>
>On 30/7/07 15:47, "Kieran Mansley" <kmansley@xxxxxxxxxxxxxx> wrote:
>
>> In that case replacing the calls (there are two in that file) to
>> netif_tx_lock_bh() with:
>>
>>  spin_lock_bh(&vif_state->np->netdev->xmit_lock);
>>
>> And similarly the calls to netif_tx_unlock_bh() with spin_unlock_bh(),
>> may solve your problem.
>>
>> If this works for you I'll make a patch that uses the kernel version to
>> decide which is appropriate.
>
>Compat issues when building PV-on-HVM drivers are patched up out-of-band in
>the special
>unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h
>header file.
>
> -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel