Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

[Xen-devel] [PATCH] Fix balloon handling of highmem pages

To: Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] Fix balloon handling of highmem pages
From: Mark Williamson <mark.williamson@xxxxxxxxxxxx>
Date: Fri, 29 Jun 2007 16:53:14 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, anthony@xxxxxxxxxxxxxxxxx
Delivery-date: Fri, 29 Jun 2007 08:51:14 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.6
I knocked up a quick patch to fix the balloon driver's handling of highmem 
pages.  Should apply cleanly to the Linux dev tree.  I can also submit it for 
3.1 if wanted.

Without this, LowTotal can go negative (given it's an unsigned integer) and 
then appears as ~4Gig, which is a bit silly.

I beliee this fixes Anthony Wright's bug #733 in Bugzilla 
(http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=733).  Credit to 
Anthony for noticing the problem, and figuring out that he was actually 
seeing an unsigned int going "negative".

Cheers,
Mark

-- 
Dave: Just a question. What use is a unicyle with no seat?  And no pedals!
Mark: To answer a question with a question: What use is a skateboard?
Dave: Skateboards have wheels.
Mark: My wheel has a wheel!

Attachment: fix-balloon-highmem.patch
Description: all/allfiles

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] Fix balloon handling of highmem pages, Mark Williamson <=