Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

RE: [Xen-devel] feature request - prevent user stupidity (eg mine)

To: "James Harper" <james.harper@xxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] feature request - prevent user stupidity (eg mine)
From: "Ian Pratt" <Ian.Pratt@xxxxxxxxxxxx>
Date: Thu, 28 Jun 2007 03:52:06 +0100
Delivery-date: Wed, 27 Jun 2007 19:50:29 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <AEC6C66638C05B468B556EA548C1A77D01166BB2@trantor>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ace0Df0qF5CVVs80T1mc5ZX/eFUSPgFCBjKg
Thread-topic: [Xen-devel] feature request - prevent user stupidity (eg mine)
> (the type was that the same Dom0 block device is used twice in the
first
> example)
> 
> Which was working great until I did a 'mkswap /dev/hda2' inside the
> domain, which really fscked things up :(
> 
> Given that there is almost no way you would ever want to publish the
> same block device to the same virtual domain more than once, would
there
> be any value in flagging that as an error when you try and start the
> domain?

I'm surprised that the existing block device safety checks don't pick up
on this, but I guess they're run before the guest is started rather than
before each virtual disk is attached.

I certainly think there's a strong argument for protecting the user from
this kind of error, at least unless they've specified 'w!' and hence
indicated they want sharing.

Anyone care to knock up a patch?

Best,
Ian

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel