[Xen-devel] Re: [PATCH RFC 3/3] Virtio draft III: example block

+static bool do_read(request_queue_t *q, struct virtio_blk *vblk,
+                   struct virtblk_req *vbr)
+{
+       unsigned long num;
+
+       vbr->out_hdr.type |= VIRTIO_BLK_T_READ;
+
+       /* Set up for reply. */
+       vblk->sg[0].page = virt_to_page(&vbr->in_hdr);
+       vblk->sg[0].offset = offset_in_page(&vbr->in_hdr);
+       vblk->sg[0].length = sizeof(vbr->in_hdr);
+       num = blk_rq_map_sg(q, vbr->req, vblk->sg+1);
+       vbr->out_hdr.id = vblk->vdev->ops->add_inbuf(vblk->vdev, vblk->sg,
+                                                    1+num, vbr);
+       if (IS_ERR_VALUE(vbr->out_hdr.id))
+               goto full;
+
+       vblk->sg[0].page = virt_to_page(&vbr->out_hdr);
+       vblk->sg[0].offset = offset_in_page(&vbr->out_hdr);
+       vblk->sg[0].length = sizeof(vbr->out_hdr);
+
+       vbr->out_id = vblk->vdev->ops->add_outbuf(vblk->vdev, vblk->sg, 1,
+                                                 vbr);

This strikes me as wasteful. Why not set up a single descriptor whichcontains both placement and the data itself?


--
error compiling committee.c: too many arguments to function


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

[Xen-devel] Re: [kvm-devel] [PATCH RFC 0/3] Virtio draft III, Avi Kivity

Next by Date:

RE: [Xen-devel] [RFC][PATCH 2/2] Add hcall to probe Xen heap, Subrahmanian, Raj

Previous by Thread:

[Xen-devel] Re: [kvm-devel] [PATCH] Lguest implemention of virtio draft III, Arnd Bergmann

Next by Thread:

[Xen-devel] Re: [PATCH RFC 3/3] Virtio draft III: example block driver, Rusty Russell

Indexes:

[Date] [Thread] [Top] [All Lists]