[Xen-devel] [PATCH] Fix spurious store changes on rename/migrate

[john.levon@xxxxxxx]

# HG changeset patch
# User john.levon@xxxxxxx
# Date 1177972216 25200
# Node ID cdda87d292fe252e18a37ca9d7c385e9e7fed1cd
# Parent  1b4f1d6508e88ba329620cb3c189d16e8f89b7fa
Fix spurious store changes on rename/migrate

_storeChanged() was incorrectly comparing a string to an sxpr, thus always
firing and causing unnecessary watches to be fired in the domU.

Signed-off-by: John Levon <john.levon@xxxxxxx>

diff --git a/tools/python/xen/xend/XendDomainInfo.py 
b/tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py
+++ b/tools/python/xen/xend/XendDomainInfo.py
@@ -885,7 +885,7 @@ class XendDomainInfo:
 
         # Check whether image definition has been updated
         image_sxp = self._readVm('image')
-        if image_sxp and image_sxp != self.info.image_sxpr():
+        if image_sxp and image_sxp != sxp.to_string(self.info.image_sxpr()):
             self.info.update_with_image_sxp(sxp.from_string(image_sxp))
             changed = True
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel