RE: [Xen-devel] [PATCH] Clear VMCS if reusing after vcpu reset

To:	"Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	RE: [Xen-devel] [PATCH] Clear VMCS if reusing after vcpu reset
From:	"Tian, Kevin" <kevin.tian@xxxxxxxxx>
Date:	Mon, 30 Apr 2007 14:45:43 +0800
Delivery-date:	Sun, 29 Apr 2007 23:44:14 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<C25B4E18.68EA%Keir.Fraser@xxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AceK7hrJaVpsNFsWQeu9LhE5uBSFagABHAUjAAACQgA=
Thread-topic:	[Xen-devel] [PATCH] Clear VMCS if reusing after vcpu reset

>From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx]
>Sent: 2007年4月30日 14:41
>On 30/4/07 07:09, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:
>
>> Clear whole page when VMCS is reused due to cpu hotplug.
>> construct_vmcs doesn't take care of all fields and some stale
>> content may make hardware unhappy.
>>
>> Signed-off-by Kevin Tian <kevin.tian@xxxxxxxxx>
>
>Which hotplug would that be? I can't see how vmx_create_vmcs() can
>be called
>more than once for any vcpu. It's called during vcpu creation and that's it
>afaics. The current check for v->arch.hvm_vmx.vmcs==NULL is
>therefore
>redundant.
>
> -- Keir

Within HVM domain:
Echo "0" > /sys/devices/system/cpu/cpuN/online;
Echo "1" > /sys/devices/system/cpu/cpuN/online; 

Hvm_vcpu_reset is invoked as the result of receiving vINIT, which 
then goes to hvm_vcpu_initialise, vmx_vcpu_initialise, 
vmx_create_vmcs.

Thanks,
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel