Re: [Xen-devel] Re: [Xen-staging] [xen-unstable] linux: User-spa

To:	Alex Williamson <alex.williamson@xxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] Re: [Xen-staging] [xen-unstable] linux: User-space grant table device.
From:	Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date:	Sat, 31 Mar 2007 16:36:59 +0100
Delivery-date:	Sat, 31 Mar 2007 16:37:05 +0100
Envelope-to:	Keir.Fraser@xxxxxxxxxxxx
In-reply-to:	<1175355236.13963.47.camel@bling>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcdzqmuWqlESTN+dEduWXQAWy6hiGQ==
Thread-topic:	[Xen-devel] Re: [Xen-staging] [xen-unstable] linux: User-space grant table device.
User-agent:	Microsoft-Entourage/11.3.3.061214



On 31/3/07 16:33, "Alex Williamson" <alex.williamson@xxxxxx> wrote:

>> + /* This flag ensures that the page tables are not unpinned before the
>> +  * VM area is unmapped. Therefore Xen still recognises the PTE as
>> +  * belonging to an L1 pagetable, and the grant unmap operation will
>> +  * succeed, even if the process does not exit cleanly.
>> +  */
>> + vma->vm_mm->context.has_foreign_mappings = 1;
> 
>    mm_context_t is arch specific, common code shouldn't be poking at it
> like this.

Good point. That part is entirely x86-specific. I'll add an ifdef.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

xen-devel

Re: [Xen-devel] Re: [Xen-staging] [xen-unstable] linux: User-space grant